Fix oauth client error #1354
Merged
Fix oauth client error #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waxlamp
approved these changes
Nov 4, 2022
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
girder-oauth-clientlibrary defaults towindow.locationfor the OAuth redirect URL. That means when trying to log in from, for example, https://dandiarchive.org/dandiset/000108, the oauth client was sendinghttps://dandiarchive.org/dandiset/000108as the redirect URL.Note that this approached worked fine before #997 since we were using "fake" hash-based URLs, but now that we're using history mode,
https://dandiarchive.org/dandiset/000108!=https://dandiarchive.org/for redirect URLs.This PR updates our oauth client to always use the current URL's
origininstead of the entire URL. Note, explicitly specifying the redirect URL was introduced in girder-oauth-client 0.8.0, so this PR also updates us to that version.Fixes #1353